[Feat/142] SocketService 메소드 구현 및 채팅 등록 API 로직 추가 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
hzee97
reviewed
Aug 10, 2024
| @@ -137,7 +138,9 @@ public enum ErrorStatus implements BaseErrorCode { | |||
| NOTIFICATION_TYPE_NOT_FOUND(HttpStatus.NOT_FOUND, "NOTI401", "잘못된 알림 타입입니다."), | |||
| NOTIFICATION_METHOD_BAD_REQUEST(HttpStatus.BAD_REQUEST, "NOTI402", "알림 생성 메소드 호출이 잘못되었습니다."), | |||
|
|
|||
| ; | |||
| // SOCKET 서버 API 호출 에러 | |||
| SOCKET_API_RESPONSE_ERR(HttpStatus.INTERNAL_SERVER_ERROR, "SOCKET501", | |||
There was a problem hiding this comment.
이 부분 SOCKET_API_RESPONSE_ERR -> SOCKET_API_RESPONSE_ERROR 로 변경하셔도 좋을 것 같습니다!
Suggested change
| SOCKET_API_RESPONSE_ERR(HttpStatus.INTERNAL_SERVER_ERROR, "SOCKET501", | |
| SOCKET_API_RESPONSE_ERROR(HttpStatus.INTERNAL_SERVER_ERROR, "SOCKET501", |
hzee97
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 개요
SocketService 메소드 구현 및 채팅 등록 API 로직 추가
🔍 변경사항
⏳ 작업 내용
📝 논의사항
인텔리제이 환경변수에
SOCKET_SERVER_URL / http://localhost:3000 추가 필요합니다!